Repository navigation
Conversation
A stale run on :8080 stopped the next one, and a kill left the port busy for a moment. State also sat in a cache folder the OS may clear; it now lives in the user config dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On a laptop the demo is started and stopped many times. A leftover run on :8080 made the next start fail, and state was kept in
~/Library/Caches, which macOS may clear.Changes
servewithout--addrtakes the first free port from 8080 to 8089 and prints the URL. An explicit--addrthat is taken still fails.serveshuts down on Ctrl-C or SIGTERM and exits 0.~/Library/Application Supporton macOS). Existing cache-folder state is not migrated; Reset rebuilds it.docs/troubleshooting.mdrow for the busy port updated.This demo starts no child processes, so there is nothing to clean up beyond the server itself.
Tests
make test vet: pass.go test -race ./internal/cli: pass.Related
Independent of localstack-samples/localstack-app-emulators PR #22 (doctor). Both touch
internal/cli/cli.goin different places.